Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use a body serializer on text/plain sdks #1596

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Jan 21, 2025

Fixes #1589

Copy link

stackblitz bot commented Jan 21, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 4784727

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@hey-api/openapi-ts Patch
@hey-api/client-axios Patch
@hey-api/client-fetch Patch
@hey-api/client-nuxt Patch
@example/openapi-ts-axios Patch
@example/openapi-ts-fastify Patch
@example/openapi-ts-fetch Patch
@example/openapi-ts-nuxt Patch
@example/openapi-ts-sample Patch
@example/openapi-ts-tanstack-angular-query-experimental Patch
@example/openapi-ts-tanstack-react-query Patch
@example/openapi-ts-tanstack-svelte-query Patch
@example/openapi-ts-tanstack-vue-query Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 3:14am

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.32%. Comparing base (548e5d8) to head (4784727).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ages/openapi-ts/src/plugins/@hey-api/sdk/plugin.ts 37.50% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1596   +/-   ##
=======================================
  Coverage   56.31%   56.32%           
=======================================
  Files         158      158           
  Lines       24803    24817   +14     
  Branches     1812     1815    +3     
=======================================
+ Hits        13969    13977    +8     
- Misses      10824    10830    +6     
  Partials       10       10           
Flag Coverage Δ
unittests 56.32% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Jan 21, 2025

Open in Stackblitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-axios@1596
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-nuxt@1596
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@1596
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-fetch@1596

commit: 4784727

@mrlubos mrlubos force-pushed the fix/text-plain-body-serializer branch from ce6281c to 4784727 Compare January 21, 2025 03:13
@mrlubos mrlubos merged commit 7eebbef into main Jan 21, 2025
17 checks passed
@mrlubos mrlubos deleted the fix/text-plain-body-serializer branch January 21, 2025 03:21
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant