aghnet: cover arpdb

internal/aghnet/arpdb_test.go

@@ -13,6 +13,15 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+func TestNewARPDB(t *testing.T) {
+	var a ARPDB
+	require.NotPanics(t, func() {
+		a = NewARPDB()
+	})
+
+	assert.NotNil(t, a)
+}
+
 // TestARPDB is the mock implementation of ARPDB to use in tests.
 type TestARPDB struct {
 	OnRefresh   func() (err error)
@@ -166,3 +175,52 @@ func TestCmdARPDB_arpa(t *testing.T) {
 		testutil.AssertErrorMsg(t, "cmd arpdb: running command: can't run", err)
 	})
 }
+
+type badReader struct{}
+
+var _ io.Reader = badReader{}
+
+func (badReader) Read(p []byte) (n int, err error) {
+	return 0, errors.Error("can't read")
+}
+
+func TestCmdARPDB_errors(t *testing.T) {
+	badReaderRunCmd := runCmdFunc(func() (r io.Reader, err error) {
+		return badReader{}, nil
+	})
+
+	a := &cmdARPDB{
+		runcmd: badReaderRunCmd,
+		parse:  parseArpA,
+		ns: &neighs{
+			mu: &sync.RWMutex{},
+			ns: make([]Neighbor, 0),
+		},
+	}
+
+	const wantErrMsg = "cmd arpdb: scanning the output: can't read"
+
+	testutil.AssertErrorMsg(t, wantErrMsg, a.Refresh())
+}
+
+func TestEmptyARPDB(t *testing.T) {
+	a := EmptyARPDB{}
+
+	t.Run("refresh", func(t *testing.T) {
+		var err error
+		require.NotPanics(t, func() {
+			err = a.Refresh()
+		})
+
+		assert.NoError(t, err)
+	})
+
+	t.Run("neighbors", func(t *testing.T) {
+		var ns []Neighbor
+		require.NotPanics(t, func() {
+			ns = a.Neighbors()
+		})
+
+		assert.Empty(t, ns)
+	})
+}