aghstrings: fix lil bug

internal/aghstrings/strings.go

@@ -1,7 +1,9 @@
 // Package aghstrings contains utilities dealing with strings.
 package aghstrings
 
-import "strings"
+import (
+	"strings"
+)
 
 // CloneSlice returns the exact copy of a.
 func CloneSlice(a []string) (b []string) {
@@ -10,7 +12,7 @@ func CloneSlice(a []string) (b []string) {
 
 // CloneSliceOrEmpty returns the copy of a or empty strings slice if a is nil.
 func CloneSliceOrEmpty(a []string) (b []string) {
-	if a == nil {
+	if len(a) == 0 {
 		return []string{}
 	}
 

internal/aghstrings/strings_test.go

@@ -9,21 +9,29 @@ import (
 )
 
 func TestCloneSlice_family(t *testing.T) {
+	a := []string{"1", "2", "3"}
+
 	t.Run("cloneslice_simple", func(t *testing.T) {
-		a := []string{"1", "2", "3"}
 		assert.Equal(t, a, CloneSlice(a))
 	})
 
 	t.Run("cloneslice_nil", func(t *testing.T) {
 		assert.Nil(t, CloneSlice(nil))
 	})
 
+	t.Run("cloneslice_empty", func(t *testing.T) {
+		assert.Nil(t, CloneSlice([]string{}))
+	})
+
 	t.Run("clonesliceorempty_nil", func(t *testing.T) {
 		assert.Equal(t, []string{}, CloneSliceOrEmpty(nil))
 	})
 
+	t.Run("clonesliceorempty_empty", func(t *testing.T) {
+		assert.Equal(t, []string{}, CloneSliceOrEmpty([]string{}))
+	})
+
 	t.Run("clonesliceorempty_sameness", func(t *testing.T) {
-		a := []string{"1", "2"}
 		assert.Equal(t, CloneSlice(a), CloneSliceOrEmpty(a))
 	})
 }