Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

移除binlog2sql插件支持 #1636

Merged
merged 1 commit into from
Jun 25, 2022
Merged

移除binlog2sql插件支持 #1636

merged 1 commit into from
Jun 25, 2022

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Jun 19, 2022

项目内集成了两套的binlog解析插件,参考 #1314 的对比,my2sql优势更明显,解析覆盖范围也更广,故没有必要继续支持binlog2sql,进行移除处理

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #1636 (97aeed2) into master (7f4dc22) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1636      +/-   ##
==========================================
- Coverage   76.02%   75.85%   -0.17%     
==========================================
  Files          92       91       -1     
  Lines       14319    14138     -181     
==========================================
- Hits        10886    10725     -161     
+ Misses       3433     3413      -20     
Impacted Files Coverage Δ
sql/models.py 96.56% <ø> (ø)
sql/notify.py 88.96% <ø> (+1.15%) ⬆️
sql/plugins/tests.py 100.00% <ø> (ø)
sql/urls.py 100.00% <ø> (ø)
sql/views.py 67.36% <ø> (-0.34%) ⬇️
sql/binlog.py 85.38% <100.00%> (+2.52%) ⬆️
sql/tests.py 98.95% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f4dc22...97aeed2. Read the comment docs.

@hhyo hhyo merged commit 2a945f5 into master Jun 25, 2022
@hhyo hhyo deleted the remove-binlog2sql branch June 25, 2022 02:15
@ayers-ltd
Copy link

my2sql 没有BINLOG_INFO 的时间展示,在定位binlog 文件的时候很不直观
binlog2sql 这个就有 BINLOG_INFO 的时间展示,是否可以把这个ui 加上

@nick2wang
Copy link
Collaborator

my2sql 没有BINLOG_INFO 的时间展示,在定位binlog 文件的时候很不直观 binlog2sql 这个就有 BINLOG_INFO 的时间展示,是否可以把这个ui 加上

目前没法做,my2sql只有在输出到文件的时候才有时间和binlog position信息

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants