-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
删除 oracle engine 中 filter_sql 实现 #2797
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2797 +/- ##
==========================================
- Coverage 78.08% 78.05% -0.04%
==========================================
Files 122 122
Lines 17311 17286 -25
==========================================
- Hits 13518 13493 -25
Misses 3793 3793 ☔ View full report in Codecov by Sentry. |
上面的描述信息显示有些问题,星号“*”被忽略掉了。例如原SQL:select a.星号,b.星号 from a,b where a.custid=b.custid; |
不要注释,没有作用的代码直接删除即可 |
好的,我这边重新修改,重新提交PR吧 |
注释的代码,我已经去掉了,麻烦审阅一下 |
代码你看下能否合并吗?这个问题出现很久了 |
我已经删除oracle.py中filter_sql函数了 |
应该没问题了 |
大佬再帮忙看下,应该没问题了 |
由于查询字段列表
sql_audit.*
中存在同名列,在Oracle数据库中执行会报错ORA-00918:未明确定义列
。原查询SQL的查询字段列表虽然也包含同名列,但因为有不同的表别名作区分,因此在数据库中执行不会报错。例如原SQL:
该SQL在Oracle数据库中可以正常执行,但在archery平台上执行会报错。