Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade plexus-compiler to 2.14.2 #4034

Conversation

marko-bekhta
Copy link
Member

Until we figure out what to do about the logging AP which may need a new release of it?

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Mar 12, 2024

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HSEARCH-\d+
    ↳ Offending commits: [e53d945, 4b6fd86]

› This message was automatically generated.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but you'll need to adjust dependabot config to avoid getting another upgrade

until we figure out the logging AP
@marko-bekhta marko-bekhta force-pushed the build/use-previous-plexus-compiler-version branch from 208d39f to e53d945 Compare March 12, 2024 16:15
@marko-bekhta
Copy link
Member Author

Mm ok 😃 I was hoping just to click "close" on the PR with plexus-compiler and then hope that Dependabot would ignore that version 🤞🏻 🙈 😄
but this should be safer 😃

@marko-bekhta
Copy link
Member Author

and here's a pr for the logging AP jboss-logging/jboss-logging-tools#106

@yrodiere
Copy link
Member

LGTM but it seems Eclipse doesn't like our code anymore...

Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
11.8% Duplication on New Code

See analysis details on SonarCloud

@yrodiere yrodiere merged commit 42bfdfa into hibernate:main Mar 13, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants