-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): Support for handling panic error #491
Conversation
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
+ Coverage 68.34% 68.37% +0.03%
==========================================
Files 27 27
Lines 3829 3836 +7
==========================================
+ Hits 2617 2623 +6
- Misses 928 929 +1
Partials 284 284
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LGTM! Please review and merge it! |
@linhbkhn95 Thank you for opening a PR, and sorry for the delay in response. Please discuss the API in the #487. |
7beba7f
to
b91288c
Compare
22f6a37
to
0adf609
Compare
@hibiken tks for your suggestion. I updated it. |
@hibiken Please review it help me |
+1 This would be a useful feature. |
This would be very useful to check if a panic happened or just a "boring" error. Hope this will get merged at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have been using this feature for a few weeks now.
Maybe github.com/test-go/testify
is an unnecessary dependency because asynq already uses github.com/google/go-cmp
in other tests so there will be some little inconsistency.
@hibiken We can merge this. |
@hibiken I don't know whether u have a concern about this PR? |
Thanks @linhbkhn95! It will be included in the next release tag. |
@kamikazechaser Please discuss API changes with me before merging these PRs. |
Why did we need it?
Example:
fixed #487