Skip to content
This repository has been archived by the owner on Nov 9, 2021. It is now read-only.

Use the double quote character to quote PostgreSQL names #369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KMahoney
Copy link

The backtick character (the core default) is MySQL specific and
non-standard. It's a syntax error in PostgreSQL.

See https://www.postgresql.org/docs/current/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS

The backtick character (the core default) is MySQL specific and
non-standard. It's a syntax error in PostgreSQL.

See https://www.postgresql.org/docs/current/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS
@KMahoney
Copy link
Author

In fact, you might want to consider making this the default. Double quotes are the ANSI standard and backticks are non-standard.

@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #369 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   81.31%   81.32%   +0.01%     
==========================================
  Files           2        2              
  Lines        2863     2865       +2     
  Branches      635      635              
==========================================
+ Hits         2328     2330       +2     
  Misses        535      535
Impacted Files Coverage Δ
dist/squel.js 72.31% <0%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d59c6...e51a201. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant