fix ping to throw (#1426)

Signed-off-by: ochikov <[email protected]>
hiero-ledger · Jan 31, 2023 · 2720c7f · 2720c7f
1 parent 48b6625
commit 2720c7f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 11 deletions.
diff --git a/src/client/Client.js b/src/client/Client.js
@@ -637,17 +637,13 @@ export default class Client {
      * @param {AccountId | string} accountId
      */
     async ping(accountId) {
-        try {
-            await new AccountBalanceQuery({ accountId })
-                .setNodeAccountIds([
-                    accountId instanceof AccountId
-                        ? accountId
-                        : AccountId.fromString(accountId),
-                ])
-                .execute(this);
-        } catch (_) {
-            // Do nothing
-        }
+        await new AccountBalanceQuery({ accountId })
+            .setNodeAccountIds([
+                accountId instanceof AccountId
+                    ? accountId
+                    : AccountId.fromString(accountId),
+            ])
+            .execute(this);
     }
 
     async pingAll() {

diff --git a/test/integration/ClientIntegrationTest.js b/test/integration/ClientIntegrationTest.js
@@ -127,6 +127,18 @@ describe("ClientIntegration", function () {
         await env.client.pingAll();
     });
 
+    it("should fail on ping", async function () {
+        this.timeout(120000);
+
+        let error = null;
+        try {
+            await env.client.ping("0.0.100"); // Non exist Node ID
+        } catch (err) {
+            error = err;
+        }
+        expect(error).to.be.an("Error");
+    });
+
     it("can set network name on custom network", async function () {
         expect(clientTestnet.ledgerId).to.be.equal(LedgerId.TESTNET);
         expect(clientPreviewNet.ledgerId).to.be.equal(LedgerId.PREVIEWNET);