Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing PublicKey methods #1520

Closed
petreze opened this issue Mar 21, 2023 · 0 comments · Fixed by #1521
Closed

Missing PublicKey methods #1520

petreze opened this issue Mar 21, 2023 · 0 comments · Fixed by #1521
Assignees
@petreze
Labels
bug Something isn't working
Milestone
2.24.0

Comments

@petreze
Copy link
Contributor

petreze commented Mar 21, 2023

Description

The SDK exposes only PublicKey.fromString(), despite having fromStringECDSA() and fromStringED25519(). Basically under the hood it uses them in order to decide which way to parse the string but we should expose them as well to be available to the user.

Steps to reproduce

PublicKey.fromStringECDSA() and PublicKey.fromStringED25519() are not exposed for the user

Additional context

No response

Hedera network

mainnet, testnet, previewnet

Version

v2.23.0

Operating system

macOS
@petreze petreze added the bug Something isn't working label Mar 21, 2023
@petreze petreze self-assigned this Mar 21, 2023
@petreze petreze mentioned this issue Mar 21, 2023
Merged
2 tasks
@Petyo-Lukanov Petyo-Lukanov added this to the 2.24.0 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petreze petreze

Labels
bug Something isn't working
Projects
None yet
Milestone
2.24.0
Development

Successfully merging a pull request may close this issue.

Expose some PublicKey methods hiero-ledger/hiero-sdk-js
2 participants
@petreze @Petyo-Lukanov