Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose some PublicKey methods #1521

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Expose some PublicKey methods #1521

merged 2 commits into from
Mar 21, 2023

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Mar 21, 2023

Description:
Adds PublicKey.fromStringECDSA() and PublicKey.fromStringED25519() support

Related issue(s):

Fixes #1520

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@petreze petreze requested a review from SimiHunjan as a code owner March 21, 2023 08:46
@petreze petreze self-assigned this Mar 21, 2023
@petreze petreze requested a review from ochikov as a code owner March 21, 2023 08:46
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Signed-off-by: Petar Tonev <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ochikov ochikov merged commit 63d1ac2 into develop Mar 21, 2023
@ochikov ochikov deleted the fix/expose-publickey-methods branch March 21, 2023 15:19
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
* expose some PublicKey methods

Signed-off-by: Petar Tonev <[email protected]>

* add unit tests

Signed-off-by: Petar Tonev <[email protected]>

---------

Signed-off-by: Petar Tonev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing PublicKey methods
2 participants