Fix HIP-573 example #1300
Merged
Fix HIP-573 example #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Akhterov <[email protected]>
Signed-off-by: Daniel Akhterov <[email protected]>
Signed-off-by: Daniel Akhterov <[email protected]>
This reverts commit dd7dfea.
petreze
requested review from
janaakhterov,
mehcode and
SimiHunjan
as code owners
ochikov
approved these changes
Oct 21, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
monokaijs
pushed a commit
to monostarter/u2u-sdk-js
that referenced
this pull request
Jul 5, 2023
* feat: implement `CustomFee.allCollectorsAreExempt Signed-off-by: Daniel Akhterov <[email protected]> * release(proto): v2.11.0 Signed-off-by: Daniel Akhterov <[email protected]> * release(sdk): v2.19.0-beta.1 Signed-off-by: Daniel Akhterov <[email protected]> * merge release-v2.19.0 into fix-hip-573-example * hip-573 adjustments * Revert "hip-573 adjustments" This reverts commit dd7dfea. * hip-573 adjustments * getting the balances with query instead of using the mirror node * get the accountIds from the wallets * wrong field name inside setAllCollectorsAreExempt() setter Signed-off-by: Daniel Akhterov <[email protected]> Co-authored-by: Daniel Akhterov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix the example regarding HIP-573
Related issue(s): #1279
Fixes #1301
Notes for reviewer:
There were some missing parts about the
setAllCollectorsAreExempt()setter and the setter itself, which are needed in order to show the functionality presented in HIP-573The missing code pieces are inside
release/v2.19.0-beta.1branch, which is merged here, insidefix-hip-573-examplebranch, in order for the functionality to be present and finish the exampleChecklist