Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some of the Github workflows #1311

Merged
merged 10 commits into from
Nov 14, 2022
Merged

Fix some of the Github workflows #1311

merged 10 commits into from
Nov 14, 2022

Conversation

ochikov
Copy link
Contributor

@ochikov ochikov commented Oct 31, 2022

Description:
Some of the Github workflows are fixed.

Related issue(s):
All of the GitHub workflows were failing. This PR is fixing some of them.
React Native workflow (for Android) is skipped due to errors and missing configs.
React Native workflow (for IOS) was skipped a long time ago.
Both of them need further investigation and rework.

Fixes #1306

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 76.90% // Head: 76.94% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (5dfeacd) compared to base (fc8801d).
Patch coverage: 48.14% of modified lines in pull request are covered.

❗ Current head 5dfeacd differs from pull request most recent head 6c7d933. Consider uploading reports for the commit 6c7d933 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1311      +/-   ##
===========================================
+ Coverage    76.90%   76.94%   +0.04%     
===========================================
  Files          292      292              
  Lines        72700    72743      +43     
===========================================
+ Hits         55908    55971      +63     
+ Misses       16792    16772      -20     
Impacted Files Coverage Δ
src/token/CustomFixedFee.js 54.54% <16.66%> (-1.34%) ⬇️
src/token/CustomFractionalFee.js 49.79% <16.66%> (-0.86%) ⬇️
src/token/CustomRoyaltyFee.js 48.69% <16.66%> (-1.04%) ⬇️
src/token/CustomFee.js 69.52% <52.17%> (-4.87%) ⬇️
src/grpc/GrpcStatus.js 77.41% <75.00%> (-0.07%) ⬇️
src/PrngTransaction.js 93.45% <100.00%> (+27.57%) ⬆️
src/channel/NodeChannel.js 87.82% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ochikov ochikov merged commit 033fd0a into develop Nov 14, 2022
@ochikov ochikov deleted the build branch November 14, 2022 08:49
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
* test cryptography unit test workflow

Signed-off-by: ochikov <[email protected]>

* only node 14

Signed-off-by: ochikov <[email protected]>

* new build

Signed-off-by: ochikov <[email protected]>

* added node 16

Signed-off-by: ochikov <[email protected]>

* extend timeout of browser test

Signed-off-by: ochikov <[email protected]>

* fix sdk build at react_native workflow

Signed-off-by: ochikov <[email protected]>

* fix to build this branch

Signed-off-by: ochikov <[email protected]>

* Disable React Native workflow due to not completenes of it

Signed-off-by: ochikov <[email protected]>

* fix commong js test to terminate console after finish

Signed-off-by: ochikov <[email protected]>

* Delete yarn-error.log

Signed-off-by: ochikov <[email protected]>

Signed-off-by: ochikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize github workflows
2 participants