Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return dependabot dependency checker #1361

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Return dependabot dependency checker #1361

merged 4 commits into from
Jan 13, 2023

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Jan 4, 2023

Signed-off-by: Petar Tonev [email protected]

Description:
Remove the configuration for renovate and return the configuration for dependabot dependency checker since it was previously working well. Dependabot is also used in all other SDKs and hedera-services, for this reason it would be better to keep the same convention here as well

Related issue(s):
Fixes #1360

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@petreze petreze requested a review from ochikov January 4, 2023 12:44
Signed-off-by: Petar Tonev <[email protected]>
.github/dependabot.yml Show resolved Hide resolved
.github/dependabot.yml Show resolved Hide resolved
@petreze petreze requested a review from steven-sheehy January 4, 2023 14:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
40.0% 40.0% Duplication

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 83.50% // Head: 83.42% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (a51cab7) compared to base (80c1ec7).
Patch has no changes to coverable lines.

❗ Current head a51cab7 differs from pull request most recent head 2eb4d04. Consider uploading reports for the commit 2eb4d04 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1361      +/-   ##
===========================================
- Coverage    83.50%   83.42%   -0.09%     
===========================================
  Files          292      292              
  Lines        72867    72867              
===========================================
- Hits         60850    60790      -60     
- Misses       12017    12077      +60     
Impacted Files Coverage Δ
src/network/AddressBookQuery.js 69.14% <0.00%> (-20.82%) ⬇️
src/channel/NodeMirrorChannel.js 97.14% <0.00%> (-2.86%) ⬇️
src/client/Client.js 85.87% <0.00%> (-0.28%) ⬇️
src/query/Query.js 92.83% <0.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ochikov ochikov merged commit 34e063e into develop Jan 13, 2023
@ochikov ochikov deleted the fix/dependabot branch January 13, 2023 09:45
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
* return dependabot dependency checker

Signed-off-by: Petar Tonev <[email protected]>

* fix contractcall integration test

Signed-off-by: Petar Tonev <[email protected]>

* test dependabot

Signed-off-by: Petar Tonev <[email protected]>

* fix contractcall integration test and dependabot config

Signed-off-by: Petar Tonev <[email protected]>

Signed-off-by: Petar Tonev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dependency bump automation
3 participants