Refactor variables #1481
Refactor variables #1481
Conversation
Signed-off-by: Petar Tonev <[email protected]>
| @@ -463,30 +463,30 @@ describe("TokenNftAllowances", function () { | |||
| .approveTokenNftAllowanceAllSerials( | |||
| nftTokenId, | |||
| env.operatorId, | |||
| spenderAccountId | |||
| delegatingSpenderAccountId | |||
| ) | |||
| .execute(env.client) | |||
| ).getReceipt(env.client); | |||
|
|
|||
| const spenderClient = Client.forLocalNode().setOperator( | |||
There was a problem hiding this comment.
This makes the test executable only against localnode. Also I don't see where we close the client.
There was a problem hiding this comment.
Both fixed with next commit
Signed-off-by: Petar Tonev <[email protected]>
|
SonarCloud Quality Gate failed.
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1481 +/- ##
===========================================
- Coverage 83.47% 83.39% -0.09%
===========================================
Files 295 295
Lines 73348 73348
===========================================
- Hits 61228 61165 -63
- Misses 12120 12183 +63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
* refactor variables Signed-off-by: Petar Tonev <[email protected]> * refactor variables and use the same client Signed-off-by: Petar Tonev <[email protected]> --------- Signed-off-by: Petar Tonev <[email protected]>
Description:
Make variables clearer
Related issue(s):
Fixes #
Notes for reviewer:
Checklist