Fix/loop nodes accounts #1493
Merged
Fix/loop nodes accounts #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ochikov <[email protected]>
Signed-off-by: ochikov <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1493 +/- ##
===========================================
- Coverage 83.47% 83.39% -0.09%
===========================================
Files 295 295
Lines 73348 73353 +5
===========================================
- Hits 61228 61170 -58
- Misses 12120 12183 +63
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: ochikov <[email protected]>
Signed-off-by: ochikov <[email protected]>
petreze
approved these changes
Mar 10, 2023
monokaijs
pushed a commit
to monostarter/u2u-sdk-js
that referenced
this pull request
Jul 5, 2023
* fix loop when we set same proxies of one node id Signed-off-by: ochikov <[email protected]> * integration tests fix Signed-off-by: ochikov <[email protected]> * refactor tests Signed-off-by: ochikov <[email protected]> * refactor tests Signed-off-by: ochikov <[email protected]> --------- Signed-off-by: ochikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix the loop when we set different proxies of one Node.
Related issue(s):
Fixes #1347
Notes for reviewer:
Checklist