Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle EvmAddress when passed to addAddress as a ContractFunctionParameter #1819

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Handle EvmAddress when passed to addAddress as a ContractFunctionParameter #1819

merged 1 commit into from
Aug 25, 2023

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Aug 24, 2023

This PR adds the possibility to pass an evm address not only as a string but as a EvmAddress object

Related issue(s):

Fixes #1816

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@petreze petreze merged commit 88f6ae4 into develop Aug 25, 2023
@petreze petreze deleted the feature/extend-add-address branch August 25, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan

@ochikov ochikov Awaiting requested review from ochikov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: ContractFunctionParameters#addAddress(param) should accept param type of EvmAddress
1 participant
@petreze