Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toJSON method for tx response, receipt and record #1859

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Add toJSON method for tx response, receipt and record #1859

merged 1 commit into from
Sep 8, 2023

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Sep 7, 2023

Description:
This PR adds toJSON() method for TransactionResponse, TransactionReceipt and TransactionRecord classes

Related issue(s):

Fixes #1855

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ochikov ochikov merged commit daf009c into develop Sep 8, 2023
@ochikov ochikov deleted the feature/add-tojson branch September 8, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ochikov ochikov ochikov approved these changes

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a toJson method on receipt and record which is consistent across all SDKs
2 participants
@petreze @ochikov