Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1950] Examples related changes #1953

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

svetoslav-nikol0v
Copy link
Contributor

@svetoslav-nikol0v svetoslav-nikol0v commented Oct 3, 2023

Description:

  • Adding try/catch block to catch and log the error and
  • Exiting the script with zero or non-zero code depending on the result after execution

Related issue(s):

Fixes #1950

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@svetoslav-nikol0v svetoslav-nikol0v changed the title Fix/1950 examples related changes [#1950] Examples related changes Oct 3, 2023
@svetoslav-nikol0v svetoslav-nikol0v force-pushed the fix/1950-examples-related-changes branch 2 times, most recently from a1abc60 to 99149e6 Compare October 3, 2023 11:01
@svetoslav-nikol0v svetoslav-nikol0v marked this pull request as ready for review October 3, 2023 13:48
@svetoslav-nikol0v svetoslav-nikol0v force-pushed the fix/1950-examples-related-changes branch from c52328a to 6c17168 Compare October 10, 2023 06:14
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8356d64) 61.35% compared to head (ca2a426) 76.49%.

❗ Current head ca2a426 differs from pull request most recent head ad2f04c. Consider uploading reports for the commit ad2f04c to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1953       +/-   ##
============================================
+ Coverage    61.35%   76.49%   +15.14%     
============================================
  Files          265      304       +39     
  Lines        66284    75800     +9516     
============================================
+ Hits         40670    57986    +17316     
+ Misses       25614    17814     -7800     

see 148 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svetoslav-nikol0v svetoslav-nikol0v force-pushed the fix/1950-examples-related-changes branch from a000a5e to 966aa81 Compare October 10, 2023 13:37
@svetoslav-nikol0v svetoslav-nikol0v force-pushed the fix/1950-examples-related-changes branch from db2d256 to ad2f04c Compare October 11, 2023 14:25
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
23.0% 23.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@svetoslav-nikol0v svetoslav-nikol0v merged commit 5c428d4 into develop Oct 16, 2023
@svetoslav-nikol0v svetoslav-nikol0v deleted the fix/1950-examples-related-changes branch October 16, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in all examples
3 participants