Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two grpc-web endpoints for node27/28 to ClientConstants.js #2019

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

ElijahLynn
Copy link
Contributor

@ElijahLynn ElijahLynn commented Nov 8, 2023

Description:
This PR adds two new grpc-web endpoints to ClientConstants.js. The endpoints have been created in Cloudflare and are pointing to the correct IPs.

Related issue(s):
https://github.com/swirlds/infrastructure/issues/4299

Notes for reviewer:
You can e.g. dig node28.swirldslabs.com +short and see that the entry points to Cloudflare's DNS balancers.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ff951ea) 76.12% compared to head (e2bda0c) 83.76%.

❗ Current head e2bda0c differs from pull request most recent head 95f313c. Consider uploading reports for the commit 95f313c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2019      +/-   ##
===========================================
+ Coverage    76.12%   83.76%   +7.64%     
===========================================
  Files          304      304              
  Lines        75854    75854              
===========================================
+ Hits         57746    63542    +5796     
+ Misses       18108    12312    -5796     
Files Coverage Δ
src/constants/ClientConstants.js 0.00% <0.00%> (ø)

... and 107 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ochikov ochikov merged commit 2345e00 into hiero-ledger:develop Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants