Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deserialize the FileAppendTransaction #2145

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix: deserialize the FileAppendTransaction #2145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/file/FileAppendTransaction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,13 @@ export default class FileAppendTransaction extends Transaction {
);

let contents;
for (let i = 0; i < bodies.length; i += nodeIds.length) {

// The increment value depends on whether the node IDs list is empty or not.
// The node IDs list is not empty if the transaction has been frozen
// before serialization and deserialization, otherwise, it's empty.
const incrementValue = nodeIds.length > 0 ? nodeIds.length : 1

for (let i = 0; i < bodies.length; i += incrementValue) {
const fileAppend =
/** @type {HashgraphProto.proto.IFileAppendTransactionBody} */ (
bodies[i].fileAppend
Expand Down