Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solve backward compatibility issues between the SDK and hedera-services v0.49 (modularized code) #2240

Merged

Conversation

svetoslav-nikol0v
Copy link
Contributor

@svetoslav-nikol0v svetoslav-nikol0v commented Apr 4, 2024

Description:

Resolves backward compatibility issues between the SDK and hedera-services v0.48 (modularized code).

Related issue(s):

Fixes #2239

Notes for reviewer:

Whenever one of the pre-existing files is updated, the SonarCloud Code Analysis check fails with [number]% Duplication on New Code (required ≤ 3%).

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (5c428d4) to head (97923fa).
Report is 58 commits behind head on main.

❗ Current head 97923fa differs from pull request most recent head 4c4ae99. Consider uploading reports for the commit 4c4ae99 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2240      +/-   ##
==========================================
+ Coverage   76.49%   84.26%   +7.76%     
==========================================
  Files         304       53     -251     
  Lines       75800    11432   -64368     
==========================================
- Hits        57986     9633   -48353     
+ Misses      17814     1799   -16015     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svetoslav-nikol0v svetoslav-nikol0v marked this pull request as ready for review April 10, 2024 11:21
@svetoslav-nikol0v svetoslav-nikol0v changed the title fix: integration tests fix: solve backward compatibility issues between the SDK and hedera-services v0.49 (modularized code) Apr 18, 2024
@svetoslav-nikol0v svetoslav-nikol0v force-pushed the 2239-fix-failing-integration-test-in-modularised-version branch 2 times, most recently from c15c168 to 36b49f5 Compare April 19, 2024 11:19
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
@svetoslav-nikol0v svetoslav-nikol0v force-pushed the 2239-fix-failing-integration-test-in-modularised-version branch from 36b49f5 to 75a3aea Compare April 19, 2024 11:48
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
agadzhalov
agadzhalov previously approved these changes Apr 24, 2024
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo, otherwise LGTM

test/integration/ContractCallIntegrationTest.js Outdated Show resolved Hide resolved
Co-authored-by: Alexander Gadzhalov <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
52.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@agadzhalov agadzhalov self-requested a review April 24, 2024 11:49
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svetoslav-nikol0v svetoslav-nikol0v merged commit 473d67c into main Apr 24, 2024
8 of 9 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the 2239-fix-failing-integration-test-in-modularised-version branch April 24, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing integration test in modularised version
4 participants