fix: reconnect to working node #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xivanov
reviewed
Jul 25, 2024
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
svetoslav-nikol0v
force-pushed
the
2360-SDK-fails-to-reconnect-to-working-node
branch
from
ade0192 to
f7fcc2f
Compare
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
svetoslav-nikol0v
dismissed stale reviews from agadzhalov and 0xivanov
via
02d74cb
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2417 +/- ##
==========================================
- Coverage 76.49% 76.17% -0.33%
==========================================
Files 304 230 -74
Lines 75800 58140 -17660
==========================================
- Hits 57986 44288 -13698
+ Misses 17814 13852 -3962 ☔ View full report in Codecov by Sentry. |
0xivanov
previously approved these changes
Jul 31, 2024
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
|
svetoslav-nikol0v
deleted the
2360-SDK-fails-to-reconnect-to-working-node
branch
agadzhalov
pushed a commit
that referenced
this pull request
Aug 1, 2024
* chore: address initial pain points Signed-off-by: Ivan Ivanov <[email protected]> * chore: bump grpc-js version Signed-off-by: Ivan Ivanov <[email protected]> * fix Signed-off-by: svetoslav-nikol0v <[email protected]> * remove example Signed-off-by: svetoslav-nikol0v <[email protected]> * chore: formatting Signed-off-by: svetoslav-nikol0v <[email protected]> * fix Signed-off-by: svetoslav-nikol0v <[email protected]> * revert: grpc old version Signed-off-by: svetoslav-nikol0v <[email protected]> * revert: pnpm-lock file Signed-off-by: svetoslav-nikol0v <[email protected]> * revert: package-lock file Signed-off-by: svetoslav-nikol0v <[email protected]> --------- Signed-off-by: Ivan Ivanov <[email protected]> Signed-off-by: svetoslav-nikol0v <[email protected]> Co-authored-by: Ivan Ivanov <[email protected]>
ivaylonikolov7
added a commit
that referenced
this pull request
Aug 1, 2024
* feat: TokenRejectTransaction js file Signed-off-by: Ivaylo Nikolov <[email protected]> * test: unit tests for TokenRejectTransaction Signed-off-by: Ivaylo Nikolov <[email protected]> * test: add integration tests for TokenRejectTransaction Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: TokenRejectFlow Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: TokenRejectFlow and TokenReject example Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: circular dependency Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: lint change Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: remove client Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: use to string for status codes Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: use ? instead of | null Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: avoid usage of token identifier Signed-off-by: Ivaylo Nikolov <[email protected]> * refator: add PublicKey type for jsdocs in type definitions Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: should not support strings conversion in token reject tx Signed-off-by: Ivaylo Nikolov <[email protected]> * fix(test): unit test should not expect token identifier property Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: use proper PublicKey path Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: better console logging when executing examples Signed-off-by: Ivaylo Nikolov <[email protected]> Signed-off-by: Alexander Gadzhalov <[email protected]> * refactor: avoid using magical number in example script Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: remove unused imports Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: improve comments naming Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: improve token naming Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: max automatic token assoc should be 100 for consistency between all sdk Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: reconnect to working node (#2417) * chore: address initial pain points Signed-off-by: Ivan Ivanov <[email protected]> * chore: bump grpc-js version Signed-off-by: Ivan Ivanov <[email protected]> * fix Signed-off-by: svetoslav-nikol0v <[email protected]> * remove example Signed-off-by: svetoslav-nikol0v <[email protected]> * chore: formatting Signed-off-by: svetoslav-nikol0v <[email protected]> * fix Signed-off-by: svetoslav-nikol0v <[email protected]> * revert: grpc old version Signed-off-by: svetoslav-nikol0v <[email protected]> * revert: pnpm-lock file Signed-off-by: svetoslav-nikol0v <[email protected]> * revert: package-lock file Signed-off-by: svetoslav-nikol0v <[email protected]> --------- Signed-off-by: Ivan Ivanov <[email protected]> Signed-off-by: svetoslav-nikol0v <[email protected]> Co-authored-by: Ivan Ivanov <[email protected]> * test(fix): update token reject outdated test Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: comments typo and improvement Signed-off-by: Ivaylo Nikolov <[email protected]> * test: temporary skip allowance tests for NFT and FT Signed-off-by: Ivaylo Nikolov <[email protected]> * test: ignore eslint warnings for skipped tests Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: add id-token permission to pages.yml workflow (#2418) Signed-off-by: Iliya Savov <[email protected]> Co-authored-by: Iliya Savov <[email protected]> Co-authored-by: Svet <[email protected]> --------- Signed-off-by: Ivaylo Nikolov <[email protected]> Signed-off-by: Alexander Gadzhalov <[email protected]> Signed-off-by: Ivan Ivanov <[email protected]> Signed-off-by: svetoslav-nikol0v <[email protected]> Signed-off-by: Iliya Savov <[email protected]> Co-authored-by: Svet <[email protected]> Co-authored-by: Ivan Ivanov <[email protected]> Co-authored-by: Iliya Savov <[email protected]> Co-authored-by: Iliya Savov <[email protected]> Co-authored-by: Alexander Gadzhalov <[email protected]>
This was referenced Aug 2, 2024
Merged
Merged
Merged
This was referenced Aug 31, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The SDK reconnects if the node is unavailable for some reason.
Fixes #2360
Checklist