feat: Add multi-signature and multi-node support for signing and addi… #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng signatures Signed-off-by: ivaylogarnev-limechain <[email protected]>
ivaylogarnev-limechain
requested review from
rwalworth,
ivaylonikolov7,
0xivanov and
agadzhalov
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2514 +/- ##
===========================================
- Coverage 76.49% 59.82% -16.68%
===========================================
Files 304 315 +11
Lines 75800 79394 +3594
===========================================
- Hits 57986 47497 -10489
- Misses 17814 31897 +14083 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ivaylogarnev-limechain <[email protected]>
|
Please check in integration tests if this works for the |
Signed-off-by: ivaylogarnev-limechain <[email protected]>
|
ivaylonikolov7
approved these changes
Sep 18, 2024
ivaylogarnev-limechain
deleted the
feat/2481-multi-node-multi-signatures
branch
ivaylogarnev-limechain
added a commit
that referenced
this pull request
Sep 19, 2024
#2514) * feat: Add multi-signature and multi-node support for signing and adding signatures Signed-off-by: ivaylogarnev-limechain <[email protected]> * test: Added signTransaction method tests Signed-off-by: ivaylogarnev-limechain <[email protected]> * test: Added some integration tests for signTransaction method Signed-off-by: ivaylogarnev-limechain <[email protected]> --------- Signed-off-by: ivaylogarnev-limechain <[email protected]>
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for multi-signature and multi-node transactions, enhancing the capabilities for signing and managing signatures.
Related issue(s):
#2481
Checklist