Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose PendingAirdropId #2567

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Conversation

ivaylonikolov7
Copy link
Contributor

@ivaylonikolov7 ivaylonikolov7 commented Oct 7, 2024

Description:

  • Exposes PendingAirdropId in exports.js so it's used for our users
  • Adds unit tests for PendingAirdropId to increase codecoverage.

Related issue(s):

Fixes #2560

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivaylo Nikolov <[email protected]>
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.42%. Comparing base (ea6280e) to head (397d0aa).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2567      +/-   ##
==========================================
+ Coverage   84.41%   84.42%   +0.01%     
==========================================
  Files         283      283              
  Lines       71021    71024       +3     
==========================================
+ Hits        59951    59963      +12     
+ Misses      11070    11061       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Oct 9, 2024

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivaylonikolov7 ivaylonikolov7 merged commit a99d9be into main Oct 10, 2024
13 checks passed
@ivaylonikolov7 ivaylonikolov7 deleted the feat/expose-pendingairdropid branch October 10, 2024 12:17
b-l-u-e pushed a commit to b-l-u-e/hedera-sdk-js that referenced this pull request Oct 13, 2024
* feat: expose PendingAirdropId

Signed-off-by: Ivaylo Nikolov <[email protected]>

* fix: allow empty props

Signed-off-by: Ivaylo Nikolov <[email protected]>

* test: add pendingairdropid unit tests

Signed-off-by: Ivaylo Nikolov <[email protected]>

---------

Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: b-l-u-e <[email protected]>
b-l-u-e pushed a commit to b-l-u-e/hedera-sdk-js that referenced this pull request Oct 13, 2024
* feat: expose PendingAirdropId

Signed-off-by: Ivaylo Nikolov <[email protected]>

* fix: allow empty props

Signed-off-by: Ivaylo Nikolov <[email protected]>

* test: add pendingairdropid unit tests

Signed-off-by: Ivaylo Nikolov <[email protected]>

---------

Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: b-l-u-e <[email protected]>
This was referenced Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose PendingAirdropId
3 participants