-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: exports WebClient for testing grpc-web proxies #2603
Conversation
Signed-off-by: Alexander Gadzhalov <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add an example with the actual use case after the export?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
==========================================
+ Coverage 84.45% 84.70% +0.24%
==========================================
Files 283 283
Lines 71084 71086 +2
==========================================
+ Hits 60035 60213 +178
+ Misses 11049 10873 -176 ☔ View full report in Codecov by Sentry. |
Description:
This PR exposes the WebClient in order to test grpc-web proxies easily in node.js environment