Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exports WebClient for testing grpc-web proxies #2603

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

agadzhalov
Copy link
Contributor

Description:
This PR exposes the WebClient in order to test grpc-web proxies easily in node.js environment

Signed-off-by: Alexander Gadzhalov <[email protected]>
@agadzhalov agadzhalov requested review from a team as code owners October 24, 2024 11:07
@agadzhalov agadzhalov requested a review from rwalworth October 24, 2024 11:07
Copy link

Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an example with the actual use case after the export?

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (9f4c6f2) to head (f702780).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2603      +/-   ##
==========================================
+ Coverage   84.45%   84.70%   +0.24%     
==========================================
  Files         283      283              
  Lines       71084    71086       +2     
==========================================
+ Hits        60035    60213     +178     
+ Misses      11049    10873     -176     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agadzhalov agadzhalov merged commit 2046860 into main Oct 24, 2024
13 checks passed
@agadzhalov agadzhalov deleted the feat/expose-web-client branch October 24, 2024 11:55
@ivaylonikolov7 ivaylonikolov7 mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants