Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix TopicMessage related tests #2799

Merged
merged 10 commits into from
Jan 21, 2025
Merged

test: fix TopicMessage related tests #2799

merged 10 commits into from
Jan 21, 2025

Conversation

ivaylonikolov7
Copy link
Contributor

Description:

  • refactored topic message query for better readability
  • fix topic tests

Related issue(s):
#2754

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ivaylonikolov7 ivaylonikolov7 changed the title feat: fix topic tests fix: topic tests Jan 20, 2025
@ivaylonikolov7 ivaylonikolov7 changed the title fix: topic tests tests: fix TopicMessage related tests Jan 20, 2025
@ivaylonikolov7 ivaylonikolov7 changed the title tests: fix TopicMessage related tests test: fix TopicMessage related tests Jan 20, 2025
0xivanov
0xivanov reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/topic/TopicMessageQuery.js still extends Query, right?
I think it should not, since it's not a HAPI query.

@ivaylonikolov7 ivaylonikolov7 marked this pull request as ready for review January 20, 2025 15:09
@ivaylonikolov7 ivaylonikolov7 requested a review from a team as a code owner January 20, 2025 15:09
@ivaylonikolov7
chore: remove console.log
dc8e833 
Signed-off-by: Ivaylo Nikolov <[email protected]>
0xivanov
0xivanov reviewed Jan 20, 2025
View reviewed changes
src/topic/TopicMessageQuery.js Show resolved Hide resolved
src/topic/TopicMessageQuery.js Outdated Show resolved Hide resolved
examples/consensus-pub-sub.js Outdated Show resolved Hide resolved
examples/consensus-pub-sub.js Outdated Show resolved Hide resolved
@ivaylonikolov7
fix: remove only
09ecc83 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
chore: reorder settimeout
72e63bb 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
fix: increase timeout delay in example
970001c 
Signed-off-by: Ivaylo Nikolov <[email protected]>
0xivanov
0xivanov approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
cannot resolve the convos though

ivaylogarnev-limechain
ivaylogarnev-limechain approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivaylonikolov7 ivaylonikolov7 merged commit 10fe710 into main Jan 21, 2025
9 checks passed
@ivaylonikolov7 ivaylonikolov7 deleted the feat/fix-topic-tests branch January 21, 2025 11:41
This was referenced Jan 21, 2025
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivaylogarnev-limechain ivaylogarnev-limechain ivaylogarnev-limechain approved these changes

@0xivanov 0xivanov 0xivanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivaylonikolov7 @0xivanov @ivaylogarnev-limechain