feat: account create transaction with key derived alias #2834
+896
−219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venilinvasilev
force-pushed
the
feat/account-create-transaction-with-key-derived-alias
branch
2 times, most recently
from
db5f836 to
eae742b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
venilinvasilev
force-pushed
the
feat/account-create-transaction-with-key-derived-alias
branch
3 times, most recently
from
a1f8f3e to
2e7d9d6
Compare
0xivanov
reviewed
Feb 3, 2025
venilinvasilev
force-pushed
the
feat/account-create-transaction-with-key-derived-alias
branch
5 times, most recently
from
30f3dd4 to
da465eb
Compare
venilinvasilev
force-pushed
the
feat/account-create-transaction-with-key-derived-alias
branch
from
da465eb to
7a66df4
Compare
0xivanov
reviewed
Feb 3, 2025
Added new APIs to AccountCreateTransaction: - `setECDSAKeyWithAlias(ECDSAPrivateKey)`: Sets ECDSA private key and alias derived from it. - `setKeyWithAlias(Key, ECDSAPrivateKey)`: Allows setting account key and a separate ECDSA private key for EVM address derivation. - `setKeyWithoutAlias(Key)`: Explicitly sets key without alias setting. Deprecated: - `setKey(Key)`: Replaced with `setKeyWithoutAlias` method. Includes unit tests for all new functionality. Signed-off-by: venilinvasilev <[email protected]>
Added integration tests for `AccountCreateTransaction` to validate new key alias APIs Replaced deprecated `setKey(Key)` references with `setKeyWithoutAlias(Key)`, aligning with the new API changes. Signed-off-by: venilinvasilev <[email protected]>
Updated all test suites to replace deprecated `setKey(Key)` calls with `setKeyWithoutAlias(Key)`, ensuring compatibility with the latest API changes. Signed-off-by: venilinvasilev <[email protected]>
Replaced all occurrences of `setKey(Key)` with `setKeyWithoutAlias(Key)` in example implementations, ensuring consistency with the latest API updates. Signed-off-by: venilinvasilev <[email protected]>
Updated a remaining deprecated reference to `setKey(Key)` in tck Signed-off-by: venilinvasilev <[email protected]>
venilinvasilev
force-pushed
the
feat/account-create-transaction-with-key-derived-alias
branch
from
7a66df4 to
293f83e
Compare
venilinvasilev
force-pushed
the
feat/account-create-transaction-with-key-derived-alias
branch
2 times, most recently
from
1eddac8 to
718149b
Compare
0xivanov
previously approved these changes
Feb 11, 2025
venilinvasilev
dismissed stale reviews from 0xivanov and ivaylogarnev-limechain
via
32b5317
venilinvasilev
force-pushed
the
feat/account-create-transaction-with-key-derived-alias
branch
from
2fb0c73 to
32b5317
Compare
Added code examples demonstrating how to use: - `setECDSAKeyWithAlias(ECDSAKey)` - `setKeyWithAlias(Key, ECDSAKey)` - `setKeyWithoutAlias(Key)` Signed-off-by: venilinvasilev <[email protected]>
venilinvasilev
force-pushed
the
feat/account-create-transaction-with-key-derived-alias
branch
from
32b5317 to
28259c2
Compare
ivaylonikolov7
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR extends the AccountCreateTransaction with the following APIs:
🚨 Deprecation Notice:
setKey(Key)is now deprecated in favor ofsetKeyWithoutAlias.Related issue(s):
#2795
✅ Checklist:
AccountCreateTransactionsetKey(Key)API ofAccountCreateTransactionsetKey(Key)) occurences with the new relevant one (setKeyWithoutAlias(Key))