Add pbIndex annotation to generated Scala code #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See 47degrees/pbdirect#21 Also tidy up the generated code slightly by putting each field on a separate line.
Remove problematic `gem system update`, as it tries to overwrite executables but it expects a confirmation 🤦♂️
pepegar
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 47degrees/pbdirect#21
If a Mu user chooses Protobuf for the serialization of messages, the pbdirect library will make use of these annotations to discover the correct index number of each field.
In the case of Avro serialization, the annotation will simply be ignored by avro4s.
Also tidied up the generated code slightly by putting each field on a separate line.