Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/add all methods generics #387

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Improvement/add all methods generics #387

merged 2 commits into from
Mar 13, 2020

Conversation

SgtSilvio
Copy link
Member

Motivation
"add all" builder methods should consume Collections and Streams with subclass elements.

Changes

  • Improved generics on "add all" builder methods
  • Added missing CheckReturnValue annotations

@SgtSilvio SgtSilvio added this to the 1.2 milestone Mar 13, 2020
@SgtSilvio SgtSilvio requested a review from AcidSepp March 13, 2020 10:21
@SgtSilvio SgtSilvio self-assigned this Mar 13, 2020
@cla-bot cla-bot bot added the cla-signed label Mar 13, 2020
@SgtSilvio SgtSilvio merged commit 751a2c6 into develop Mar 13, 2020
@SgtSilvio SgtSilvio deleted the improvement/add-all-methods-generics branch March 13, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AcidSepp AcidSepp AcidSepp approved these changes

Assignees

@SgtSilvio SgtSilvio

Labels
cla-signed improvement
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@SgtSilvio @AcidSepp