Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Llama model save for full param train #3057

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Fix Llama model save for full param train #3057

merged 2 commits into from
Mar 30, 2024

Conversation

marko1616
Copy link
Contributor

What does this PR do?

Fix Llama model save for full param train(also GaLore)

Before submitting

@hiyouga hiyouga self-requested a review March 30, 2024 16:06
@hiyouga hiyouga merged commit de3564f into hiyouga:main Mar 30, 2024
1 check passed
@hiyouga
Copy link
Owner

hiyouga commented Mar 30, 2024

LGTM!

@hiyouga hiyouga added the solved This problem has been already solved label Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyouga hiyouga hiyouga approved these changes

Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marko1616 @hiyouga