-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"add support for vllm api stop parameter" #3527
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
42edc81
"add support for vllm api stop parameter"
zhaonx 1abd55d
Merge branch 'main' of https://github.com/zhaonx/LLaMA-Factory into dev
8064575
”add stop parameter in chat.py“
7ae7ae6
Update generating_args.py
hiyouga f32eefa
Update generating_args.py
hiyouga 17d0005
Update vllm_engine.py
hiyouga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
from dataclasses import asdict, dataclass, field | ||
from typing import Any, Dict | ||
from typing import Any, Dict, Union, Optional, List | ||
|
||
|
||
@dataclass | ||
|
@@ -46,7 +46,10 @@ class GeneratingArguments: | |
default=1.0, | ||
metadata={"help": "Exponential penalty to the length that is used with beam-based generation."}, | ||
) | ||
|
||
stop: Union[Optional[str], List[str]] = field( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The arguments in GeneratingArguments should also be contained in the https://huggingface.co/docs/transformers/v4.40.2/en/main_classes/text_generation#transformers.GenerationConfig, but it is not now, we will delete it |
||
default=None, | ||
metadata={"help": "List of strings or string that stop the generation when they are generated. The returned output will not contain the stop strings."}, | ||
) | ||
def to_dict(self) -> Dict[str, Any]: | ||
args = asdict(self) | ||
if args.get("max_new_tokens", -1) > 0: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need to insert it into generating_args