-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support EXAONE3.0 Model #5585
Support EXAONE3.0 Model #5585
Conversation
src/llamafactory/data/template.py
Outdated
format_assistant=StringFormatter(slots=["{{content}}[|endofturn|]\n"]), | ||
format_separator=EmptyFormatter(slots=["\n"]), | ||
format_prefix=EmptyFormatter(slots=[""]), | ||
stop_words=["[|endofturn|]"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the eos token is already [|endofturn|]
, we do not need stop_words here
src/llamafactory/data/template.py
Outdated
name="exaone", | ||
format_user=StringFormatter(slots=["[|user|]{{content}}\n[|assistant|]"]), | ||
format_system=StringFormatter(slots=["[|system|]{{content}}[|endofturn|]\n"]), | ||
format_assistant=StringFormatter(slots=["{{content}}[|endofturn|]\n"]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate new line, remove format_assistant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the readme, we only include the model families. It is recommended to only add template and constants rather than adding them to the readme. Thanks
Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Support EXAONE3.0-7.8B Model introduced by LGAI
Fixes # (issue)
Before submitting