Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EXAONE3.0 Model #5585

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Support EXAONE3.0 Model #5585

merged 7 commits into from
Sep 30, 2024

Conversation

shing100
Copy link
Contributor

What does this PR do?

Support EXAONE3.0-7.8B Model introduced by LGAI

Fixes # (issue)

Before submitting

format_assistant=StringFormatter(slots=["{{content}}[|endofturn|]\n"]),
format_separator=EmptyFormatter(slots=["\n"]),
format_prefix=EmptyFormatter(slots=[""]),
stop_words=["[|endofturn|]"],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the eos token is already [|endofturn|], we do not need stop_words here

name="exaone",
format_user=StringFormatter(slots=["[|user|]{{content}}\n[|assistant|]"]),
format_system=StringFormatter(slots=["[|system|]{{content}}[|endofturn|]\n"]),
format_assistant=StringFormatter(slots=["{{content}}[|endofturn|]\n"]),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate new line, remove format_assistant

Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the readme, we only include the model families. It is recommended to only add template and constants rather than adding them to the readme. Thanks

@shing100
Copy link
Contributor Author

shing100 commented Sep 30, 2024

Thank you.

@hiyouga hiyouga self-requested a review September 30, 2024 08:36
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga merged commit ef84aac into hiyouga:main Sep 30, 2024
12 checks passed
@hiyouga hiyouga added the solved This problem has been already solved label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants