Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix VllmEngine: 将inputs参数替换为prompt #5973

Merged
merged 2 commits into from
Nov 10, 2024
Merged

fix VllmEngine: 将inputs参数替换为prompt #5973

merged 2 commits into from
Nov 10, 2024

Conversation

JJJJerry
Copy link
Contributor

@JJJJerry JJJJerry commented Nov 9, 2024

What does this PR do?

在vllm 0.6.3版本的vllm.AsyncLLMEngine.generate函数中，将inputs参数换成了prompt参数。现将LLaMA-Factory也同步更改一下。

Before submitting

hiyouga
hiyouga approved these changes Nov 10, 2024
View reviewed changes
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga merged commit 40a2fcc into hiyouga:main Nov 10, 2024
12 checks passed
@hiyouga hiyouga added the solved This problem has been already solved label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyouga hiyouga hiyouga approved these changes

Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JJJJerry @hiyouga