Skip to content
This repository has been archived by the owner on Oct 3, 2020. It is now read-only.

Unused PVCs (e.g. EBS volumes): also check for Deployments #70

Closed
hjacobs opened this issue Apr 23, 2020 · 1 comment · Fixed by #71
Closed

Unused PVCs (e.g. EBS volumes): also check for Deployments #70

hjacobs opened this issue Apr 23, 2020 · 1 comment · Fixed by #71
Assignees

Comments

@hjacobs
Copy link
Owner

hjacobs commented Apr 23, 2020

Some people run Deployments with volumes. The PVC check should consider this. It's pretty trivial to add a check for Deployments here: https://github.com/hjacobs/kube-janitor/blob/master/kube_janitor/resource_context.py#L19

@hjacobs
Copy link
Owner Author

hjacobs commented Apr 23, 2020

There is a valid use case for using a PVC with a Deployment: a PVC can be backed by a "write many" volume such as AWS EFS. The EFS volume can be mounted by multiple Pods, so a Deployment can be used.

@hjacobs hjacobs self-assigned this Apr 23, 2020
hjacobs added a commit that referenced this issue Apr 23, 2020
hjacobs added a commit that referenced this issue Apr 23, 2020
* #70 test PVC reference from Deployment

* #70 also consider PVC references from Deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant