PLATUI-847: Fix accessibility issue with hmrcHeader #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsb
requested changes
Dec 2, 2020
timsb
requested changes
Dec 2, 2020
timsb
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves accessibility issue with hmrcHeader when displayHmrcBanner is set to true.
Previously this component defined two top-level 'banner' landmarks failing automated Axe accessibility tests. On advice from the HMRC accessibility team, the HMRC banner has been moved inside HEADER so that screen-reader users read the banner as part of the overall header and can skip to the main content more easily.
Related unresolved GDS issues:
alphagov/govuk-frontend#1604
alphagov/govuk-frontend#1679
This change has been tested on the following devices/browsers:
https://www.gov.uk/service-manual/technology/designing-for-different-browsers-and-devices
June 2020
Windows 10, IE11
Windows 10, Edge 87
Windows 10, Firefox 83
Mac OS Catalina Safari 14
Mac OS Catalina Safari 14 with Voiceover
Mac OS Catalina Firefox 81
Mac OS Catalina Chrome 87
iPhone 8 Chrome
iPhone 8 Safari
Android 9, Samsung Galaxy S10, Chrome
Android 9, Samsung Galaxy S10, Samsung Internet