Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to load html #349

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kiamesdavies
Copy link

Thank you for contributing to this project!

If you haven't already done so, please agree to the Contributor's License Agreement: https://github.com/MachinePublishers/jBrowserDriver/blob/master/CLA-rev2-digital.txt

You can edit that file to add your digital signature to the bottom.

@hollingsworthd
Copy link
Owner

hollingsworthd commented Jul 23, 2019

Hello this is a great feature and thanks for creating it. I'm a little torn though, the intention of WebDriver is to support only all the interactions a user might have with a web page (and not go beyond that... although there are some grey areas). I wonder if it works to do driver.get("file:///somepath.html"); or driver.get("data:text/html;charset=utf-8," + someHtml)

Also I would be a little bit concerned about deviating from the Selenium API. And for embedded web servers in java there are lots of good options and hacking together a simple server can be done similar to https://github.com/MachinePublishers/jBrowserDriver/blob/master/src/com/machinepublishers/jbrowserdriver/diagnostics/HttpServer.java

I like the feature a lot but am not sure at this point about adding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants