This repository has been archived by the owner on Oct 1, 2021. It is now read-only.
Ignore bravia televisions from songpal detection #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was discovered that sony bravia televisions do also use the very same protocol for communication as "songpal" component, causing them to be added to homeassistant although all relevant parts for them are not yet supported. This patch adds an ignore for those devices for the time being, at some later point the python-songpal will likely be extended to work more properly on those devices and this may be removed. Related to home-assistant/core#13022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered that sony bravia televisions do also use the very same
protocol for communication as "songpal" component, causing them to be added
to homeassistant although all relevant parts for them are not yet supported.
This patch adds an ignore for those devices for the time being,
at some later point the python-songpal will likely be extended to work
more properly on those devices and this may be removed.
Related to home-assistant/core#13022