-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Almond to 2.0.0 #2042
Update Almond to 2.0.0 #2042
Conversation
Also, change the version scheme of the add-on to be the Almond version number + a monotonically increasing build number, so we can convert back the add-on version to the Almond version, for bug triaging.
We need node 12, which is not built for armv6
Co-authored-by: Franck Nijhof <[email protected]>
Only for clarification, Ada was never a replacement for Almond's voice assist. It was a concept to show how you can build a voice assistant based on tts/stt API of Home Assistant which allows to plug&play different provider of such service. |
Yeah I don't mind that Ada continues to exist with that purpose. I know people have custom intents built with Home Assistant's conversation integration and those don't work through Almond. But the common case is for people to combine Ada and Almond (in fact, it is often conflated in social media and support forums) so we should document the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally, including an upgrade path for existing users, which seems to work fine.
As for audio, I did get output, so that works. Input didn't work on my end, however, I blame my $1.50 USB mini mic for that, I don't see a reason for it being a general issue (@balloob and some others also tested the upstream version, which also showed it working).
So from my end, I think it is OK 👍
Also, change the version scheme of the add-on to be the Almond
version number + a monotonically increasing build number, so we
can convert back the add-on version to the Almond version, for
bug triaging.