Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade yarl to 1.0.0 #11660

Closed
wants to merge 2 commits into from
Closed

Upgrade yarl to 1.0.0 #11660

wants to merge 2 commits into from

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 15, 2018

Description:

Changelog: https://github.com/aio-libs/yarl/blob/master/CHANGES.rst#100-2018-01-15

Example entry for configuration.yaml (if applicable):

http:

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@fabaff fabaff requested review from andrey-git and a team as code owners January 15, 2018 16:14
@fabaff
Copy link
Member Author

fabaff commented Jan 15, 2018

The quote/unquote issue is back...

@balloob
Copy link
Member

balloob commented Jan 17, 2018

Let's not upgrade yarl until aiohttp 3 lands.

@balloob balloob closed this Jan 19, 2018
@balloob balloob deleted the upgrade-yarl branch January 19, 2018 06:34
@fabaff fabaff mentioned this pull request Jan 25, 2018
Closed
@Danielhiversen Danielhiversen mentioned this pull request Feb 8, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrey-git andrey-git Awaiting requested review from andrey-git

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabaff @balloob @homeassistant