Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeAliasType not callable in senz #118872

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jun 5, 2024

Proposed change

Accidentally introduced in #117633.
PEP 695 type alias types are not callable and will raise a TypeError if called.

type SENZDataUpdateCoordinator = DataUpdateCoordinator[dict[str, Thermostat]]

# bad
coordinator = SENZDataUpdateCoordinator(...)  # TypeError: 'typing.TypeAliasType' object is not callable

# good
coordinator: SENZDataUpdateCoordinator = DataUpdateCoordinator(...)

Mypy just added a check for it upstream. It will be included in the next mypy-dev release. python/mypy#17320

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jun 5, 2024

Hey there @milanmeu, mind taking a look at this pull request as it has been labeled with an integration (senz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of senz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign senz Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cdce8p cdce8p added this to the 2024.6.0 milestone Jun 5, 2024
@cdce8p cdce8p added the smash Indicator this PR is close to finish for merging or closing label Jun 5, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cdce8p 👍

../Frenck

@frenck frenck merged commit 68a537a into home-assistant:dev Jun 5, 2024
24 checks passed
@cdce8p cdce8p deleted the fix-senz branch June 5, 2024 10:48
@cdce8p cdce8p mentioned this pull request Jun 5, 2024
20 tasks
frenck pushed a commit that referenced this pull request Jun 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cherry-picked cla-signed integration: senz Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants