-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aiohttp to 3.10.6rc2 #126468
Bump aiohttp to 3.10.6rc2 #126468
Conversation
changelog: aio-libs/aiohttp@v3.10.5...v3.10.6rc0 The big change for HA is that the cookiejar no longer does a linear search to expire cookies which was a problem for us because over time the cookiejar would grow and more and more run time would be spent
It looks like it contains some breaking changes... a lot of tests are failing |
It's our mocking missing some methods,
|
I think there is another issue tracking it in aio-libs/aiohttp#9267 |
We need to address the regression upstream before we can move this forward |
aio-libs/aiohttp#9271 cooking now |
Tests pass now. Everything looks good.. ... but the wheels won't build |
ERROR: Cannot install aiohttp==3.10.6rc1 because these package versions have conflicting dependencies. The conflict is caused by: |
The pypi upload only uploaded some of the wheels. Was good enough to get a clean run though so proceeding to release. |
We decided to delay the release to fix a display issue with the docs via aio-libs/aiohttp-theme#61 so I'll get rc2 aio-libs/aiohttp#9273 published instead so we can bump here since rc1 failed to upload the source tarball because GitHub was being flakey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bdraco 👍
../Frenck
- [ ] rc1 wheels https://github.com/home-assistant/core/actions/runs/11004230559Proposed change
changelog: aio-libs/aiohttp@v3.10.5...v3.10.6rc2
The big change for HA is that the cookiejar no longer does a linear search (now a heapq) to expire cookies which was a problem for us with the shared sessions because over time the cookiejar would grow and more and more run time would be spent there the longer HA was running.
Additionally the middleware performance penalty which accounted for 40-60% of the handler run time has been solved
If all goes well we should be able to release 3.10.6 during beta.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: