Add number entities to set target temp for cooling programs in ViCare #127267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFenner
commented
Oct 11, 2024
| @@ -97,13 +97,22 @@ | |||
| "name": "Comfort temperature" | |||
| }, | |||
| "normal_heating_temperature": { | |||
| "name": "[%key:component::vicare::entity::number::normal_temperature::name%]" | |||
| "name": "Normal temperature (heating)" | |||
There was a problem hiding this comment.
Open for better naming suggestions
There was a problem hiding this comment.
What does normal mean in this context? Default?
Default heating temperature?
There was a problem hiding this comment.
It's the program name: normal, reduced, comfort, and there are some others (not yet integrated). these programs are usually cycled through on a schedule.
There was a problem hiding this comment.
Why don't you call it Normal heating temperature?
joostlek
approved these changes
Oct 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: