Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onvif PTZ GotoPreset #34420

Merged
merged 4 commits into from
Apr 24, 2020

Conversation

Geronimo2015
Copy link
Contributor

@Geronimo2015 Geronimo2015 commented Apr 19, 2020

Proposed change

Support for moving onvif camera's to presets was missing.
With this change one can execute a GotoPreset command via OnVif to move/pan/tilt/zoom a camera to a preset by specifying the GotoPreset profile token.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@homeassistant
Copy link
Contributor

Hi @Geronimo2015,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Processed flake8 error
@homeassistant
Copy link
Contributor

Hi @Geronimo2015,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Removed trailing spaces
@homeassistant
Copy link
Contributor

Hi @Geronimo2015,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@MartinHjelmare MartinHjelmare changed the title Added PTZ GotoPreset support Add onvif PTZ GotoPreset Apr 19, 2020
@MartinHjelmare
Copy link
Member

Format the code by running black from the project root and commit the changes.

black --fast homeassistant tests

black formatted code
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Geronimo2015
Copy link
Contributor Author

Geronimo2015 commented Apr 23, 2020 via email

@MartinHjelmare
Copy link
Member

Please add a link to a docs PR, in the description of this PR, that describes the new service option. Then we can merge.

https://www.home-assistant.io/integrations/onvif/#service-onvifptz

@Geronimo2015
Copy link
Contributor Author

Geronimo2015 commented Apr 23, 2020 via email

@frenck
Copy link
Member

frenck commented Apr 24, 2020

Thanks for adding documentation @Geronimo2015 👍

@MartinHjelmare MartinHjelmare merged commit d416029 into home-assistant:dev Apr 24, 2020
@hunterjm hunterjm mentioned this pull request Apr 24, 2020
20 tasks
@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants