-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onvif PTZ GotoPreset #34420
Add onvif PTZ GotoPreset #34420
Conversation
Hi @Geronimo2015, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Processed flake8 error
Hi @Geronimo2015, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Removed trailing spaces
Hi @Geronimo2015, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Format the code by running black from the project root and commit the changes.
|
black formatted code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks
…On Thu, Apr 23, 2020, 22:01 Martin Hjelmare ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34420 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5WAQZR6HQLM6ZU3TOHF6LROCNBDANCNFSM4MLW6SSA>
.
|
Please add a link to a docs PR, in the description of this PR, that describes the new service option. Then we can merge. https://www.home-assistant.io/integrations/onvif/#service-onvifptz |
Ok will do so tomorrow
…On Thu, Apr 23, 2020, 22:02 Martin Hjelmare ***@***.***> wrote:
Please add a link to a docs PR, in the description of this PR, that
describes the new service option. Then we can merge.
https://www.home-assistant.io/integrations/onvif/#service-onvifptz
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34420 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5WAQ23QY7IQ2UCXLS2KFLROCNGRANCNFSM4MLW6SSA>
.
|
Thanks for adding documentation @Geronimo2015 👍 |
Proposed change
Support for moving onvif camera's to presets was missing.
With this change one can execute a GotoPreset command via OnVif to move/pan/tilt/zoom a camera to a preset by specifying the GotoPreset profile token.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: