Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add All wrapper to deprecated Plex schema #34552

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Add All wrapper to deprecated Plex schema #34552

merged 1 commit into from
Apr 22, 2020

Conversation

jjlawren
Copy link
Contributor

Proposed change

Fix incomplete schema from #34546.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@jjlawren jjlawren mentioned this pull request Apr 22, 2020
Merged
20 tasks
MartinHjelmare
MartinHjelmare approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jjlawren jjlawren added this to the 0.109.0 milestone Apr 22, 2020
@balloob balloob merged commit 1160126 into home-assistant:dev Apr 22, 2020
balloob pushed a commit that referenced this pull request Apr 23, 2020
@jjlawren @balloob
Add All wrapper to deprecated Plex schema (#34552)
eb98301
@jjlawren jjlawren deleted the fix_plex_deprecated_schema branch April 24, 2020 03:36
@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
@balloob balloob added the bugfix label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: plex small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.109.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jjlawren @MartinHjelmare @balloob @homeassistant