Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore ability to overwrite homekit max temp bound #34612

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Restore ability to overwrite homekit max temp bound #34612

merged 1 commit into from
Apr 23, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 23, 2020 •
edited
Loading

Proposed change

This restores the ability to overwrite the top boundary
but keeps the safety for the lower boundary that was added
to prevent the crash in the home app.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco bdraco changed the title Homekit overwrite top temp bound ok Restore ability to overwrite homekit max temp bound Apr 23, 2020
@bdraco bdraco added this to the 0.109.0 milestone Apr 23, 2020
@bdraco
Restore the ability to overwrite the homekit top temp bound
66280f2 
* This restores the ability to overwrite the top boundary
but keeps the safety for the lower boundary that was added
to prevent the crash in the home app.
@balloob
Copy link
Member

balloob commented Apr 23, 2020

Is restoring this ability really a 1500 line endavor or did some other commits get in ?

@bdraco bdraco force-pushed the homekit_overwrite_top_temp_bound_ok branch from 23ceae1 to 66280f2 Compare April 23, 2020 20:07
@balloob
Copy link
Member

balloob commented Apr 23, 2020

Ah, yes that makes more sense 😆

@bdraco
Copy link
Member Author

bdraco commented Apr 23, 2020

Is restoring this ability really a 1500 line endavor or did some other commits get in ?

It was doing it on top of the config flow branch and forgot to cherry pick it back

@balloob balloob merged commit 7ff196d into home-assistant:dev Apr 23, 2020
balloob pushed a commit that referenced this pull request Apr 24, 2020
@bdraco @balloob
Restore ability to overwrite homekit max temp bound (#34612)
93aa478
@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed core has-tests integration: homekit
Projects
None yet
Milestone
0.109.0
Development

Successfully merging this pull request may close these issues.

0.109.0b0 HomeKit Climate Max Temp
3 participants
@bdraco @balloob @homeassistant