Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay sync for Google and limit updates to relevant info #34622

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 24, 2020

Breaking change

Proposed change

Now that the cloud starts up faster, it was capturing entity registry changes it previously was not. Since Google does not allow partial sync like Alexa, it would update all entities, however, since this happened before Home Assistant was fully started, not all entities were loaded yet. Fixed this by using the delayed sync helper, which waits 15 seconds and is also used for preference updates.

Also updated both Alexa/Google entity registry listeners to only treat an entity registry update relevant if important attributes have changed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (cloud) you are listed as a codeowner for? Thanks!

@pvizeli pvizeli merged commit d3bbd9e into dev Apr 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the improve-cloud-entity-sync branch April 24, 2020 08:49
@balloob balloob mentioned this pull request Apr 24, 2020
@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
@balloob balloob added the bugfix label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Z-Wave and MQTT integration devices disappearing from Google Home when restarting Home Assistant
3 participants