Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to maxcube-api 0.3.0 version #45123

Closed
wants to merge 1 commit into from

Conversation

unaiur
Copy link
Contributor

@unaiur unaiur commented Jan 13, 2021

Upgrade maxcube-api to solve bugs fixed in last 3 years.

Proposed change

Upgrade maxcube-api dependency to latest version to resolve several bug that were fixed in the 3 years since 0.1.0 was released. For example:

  • Fix actual temperature reading from wall thermostats
  • Allow to set temperatures below 8 Celsius degrees
  • Fix memory leak
  • Update room names when they are renamed.

Type of change

  • [*] Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass Test are failing because of some unrelated dependency: ERROR: Could not find a version that satisfies the requirement httplib2==0.10.3
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Upgrade maxcube-api to solve bugs fixed in last 3 years.
@homeassistant
Copy link
Contributor

Hi @unaiur,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added integration: maxcube small-pr PRs with less than 30 lines. labels Jan 13, 2021
@unaiur unaiur closed this Jan 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2021
@unaiur unaiur deleted the upgrade-maxcube-api-0.2.0 branch March 9, 2021 07:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maxcube (eQ-3 MAX!) is showing wrong temperatue if it is greater than 25.6 Celsius
2 participants