Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add climate domain to template integration #50107

Closed
wants to merge 10 commits into from

Conversation

davidlang42
Copy link

@davidlang42 davidlang42 commented May 5, 2021

Proposed change

The existing template integration implements most of the available domains in HA, but not a template climate entity. I have added the climate domain to the template integration, implementing the MVP features of:

  • entity availability (template)
  • entity name (friendly_name)
  • hvac mode (set action, value template and hvac_modes list)
  • fan mode (set action, value template and fan_modes list)
  • target temperature (set action, value templates, min/max/step temp, temp)

Note, the following features of the climate domain are not yet implemented:

  • temperature range
  • aux heater
  • preset modes
  • target humidity
  • swing modes

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@davidlang42 davidlang42 marked this pull request as ready for review May 10, 2021 23:01
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 10, 2021
@davidlang42
Copy link
Author

davidlang42 commented Jun 11, 2021

Hi @PhracturedBlue @tetienne is there any chance one of you could review this? It fills an important gap in the built in template integration and followed all the same paradigms as the existing template code. Should be a quick one!

@github-actions github-actions bot removed the stale label Jun 11, 2021
@FrnchFrgg

This comment has been minimized.

@FrnchFrgg

This comment has been minimized.

@davidlang42

This comment has been minimized.

@emontnemery

This comment has been minimized.

@emontnemery emontnemery closed this Jul 5, 2021
@emontnemery emontnemery reopened this Jul 5, 2021
@emontnemery
Copy link
Contributor

(Close + open to retrigger CI)

@emontnemery
Copy link
Contributor

Three general comments:

  • Please update the PR to make use of the _attr-* attributes, for example drop the def name() and replace it with just assigning to self._attr_name.
  • Don't do unconditional optimistic state updates, for example in async_set_fan_mode, only update self._fan_mode if there is no self._fan_mode_template
  • Please add tests

@FrnchFrgg

This comment has been minimized.

@emontnemery
Copy link
Contributor

emontnemery commented Jul 6, 2021

@FrnchFrgg I'm not listed as a codeowner of the template integration though, so it's correct that I'm not tagged

"codeowners": ["@PhracturedBlue", "@tetienne"],

This PR adds @home-assistant/core as codeowner: #52592

(I've hidden most of the discussion about codeowners as off topic)

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 4, 2021
@emontnemery
Copy link
Contributor

@davidlang42 Please see my comments here: #50107 (comment), the first one is a matter of style so not required but number 2 or 3 needs to be addressed.

@github-actions github-actions bot removed the stale label Oct 5, 2021
@davidlang42
Copy link
Author

@davidlang42 Please see my comments here: #50107 (comment), the first one is a matter of style so not required but number 2 or 3 needs to be addressed.

Thanks @emontnemery , I fully intend to finish this off but unfortunately I've got my university thesis due on 9th November so will be prioritising that for the next month. Is it possible to keep this PR open for another month? If not, that's okay, I'll just start a new one when I can finish it

@emontnemery
Copy link
Contributor

@davidlang42 sure, no problem 👍

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 4, 2022
@github-actions github-actions bot closed this Jan 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants