-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add climate domain to template integration #50107
Conversation
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Hi @PhracturedBlue @tetienne is there any chance one of you could review this? It fills an important gap in the built in template integration and followed all the same paradigms as the existing template code. Should be a quick one! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
(Close + open to retrigger CI) |
Three general comments:
|
This comment has been minimized.
This comment has been minimized.
@FrnchFrgg I'm not listed as a codeowner of the template integration though, so it's correct that I'm not tagged
This PR adds @home-assistant/core as codeowner: #52592 (I've hidden most of the discussion about codeowners as off topic) |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
@davidlang42 Please see my comments here: #50107 (comment), the first one is a matter of style so not required but number 2 or 3 needs to be addressed. |
Thanks @emontnemery , I fully intend to finish this off but unfortunately I've got my university thesis due on 9th November so will be prioritising that for the next month. Is it possible to keep this PR open for another month? If not, that's okay, I'll just start a new one when I can finish it |
@davidlang42 sure, no problem 👍 |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
The existing template integration implements most of the available domains in HA, but not a template
climate
entity. I have added the climate domain to the template integration, implementing the MVP features of:Note, the following features of the
climate
domain are not yet implemented:Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:The manifest file has all fields filled out correctly.Updated and included derived files by running:
python3 -m script.hassfest
.New or updated dependencies have been added torequirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.Untested files have been added to.coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: