-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle integrations with empty services or failing to load during service description enumeration #95911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs more manual testing on production |
bdraco
commented
Jul 5, 2023
shell_command is a weird case here shell_command % cat services.yaml Empty file, shell_command services are dynamically createdAllowing it to be null is a problem because it breaks the frontend
|
balloob
approved these changes
Jul 6, 2023
balloob
pushed a commit
that referenced
this pull request
Jul 6, 2023
…vice description enumeration (#95911) * wip * tweaks * tweaks * add coverage * complain loudly as we never execpt this to happen * ensure not None * comment it
Merged
joostlek
pushed a commit
to joostlek/core
that referenced
this pull request
Jul 6, 2023
…vice description enumeration (home-assistant#95911) * wip * tweaks * tweaks * add coverage * complain loudly as we never execpt this to happen * ensure not None * comment it
I wonder if this only partly fixed the issue: danieldotnl/ha-multiscrape#215 they seem too have a partial services.yaml. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
fixes #95581
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: